feat(gce): add support for hyperdisk in GCE #10149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarulg
requested review from
link108,
jasonmcintosh,
christosarvanitis and
dbyron-sf
|
The following commits need their title changed:
Please format your commit title into the form:
This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here. |
There was a problem hiding this comment.
@edgarulg can you update the branch and the PR title please?
edgarulg
changed the title
jasonmcintosh
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
hyperdisk-balancedin Spinnaker for GCE. See: https://cloud.google.com/compute/docs/disks/hyperdisksIn the following changes, I added
hyperdisk-balancedas option for Persistent Disk in the deploy stage when using GCE in Spinnaker.This allows any user to configure their GCE instance to use hyperdisk. The backend already supports this new persistent disk type with the following PR: spinnaker/clouddriver#6288